Request queue support #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Collect queue_duration_us in Transaction.Plug The headers are always lowercase, so this will resolve any case sensitivity issues * Derive the queue duration when a transaction is completed * Include the queueDuration in the `Transaction.Event` * Extract request queue time like the Ruby agent does * Include both micro and fractional seconds * Report queueDuration in seconds with the TransactionEvent * Collect a WebFrontend/QueueDuration metric * mix format * Review feedback (tests failing currently) * Use the proper metric to report queue time
mattbaker
approved these changes
Oct 10, 2019
|
Pumped! Thanks for getting this in so quickly. |
|
I wanna spin up an app running this branch before merging just to verify the UI lights up as expected |
|
works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for tracking Request Queuing based on the
x-request-startheader that can optionally be added when a request first hits a load balancerThanks for contributing @sb8244 !
sidekick/ @mattbaker
closes #141