-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
thezackm/unix entity definition #14
Conversation
updated to match new schema definition Co-authored-by: Irene <irenemlcarron@gmail.com>
a8ade26
to
8c0df5e
Compare
@IreneMLC @jfjoly - question came up that I'm unsure how to address. Hoping you can help: Is it possible right now to create these definitions and limit them based on part of the event attributes? Something like this perhaps?
Ultimately I think the confusion is how granular can we get on parsing/faceting unique entities out of a comment event type. |
@thezackm the osName can be a golden tags that will be shown in the UI. The user can create a filter to see only the entities of this type and with the tag osName='AIX'. |
Multiple definitions could work well if we had a metric attribute that could be used like that |
do we have an example of what this would look like? I can get a PR submitted to the Unix integration to add an osVersion field (or something like it); but I'd like to see a working example first so I can make sure I'm following correctly. Thanks! |
What we use as a 'condition' is just another attribute in the telemetry (something like "attributeName":"attributeValue"), but I'm not familiar with the telemetry from that integration so I do not know what the actual value would be, but for example in this metric we could use the value of this attribute to know that it's related to EKS |
@thezackm can we find a more precise condition? |
@jfjoly - will it be possible to match on domain: EXT
type: UNIX_HOST
synthesis:
name: hostname
identifier: hostname
conditions:
- attribute: eventType
prefix: unixMonitor
compositeMetrics:
goldenMetrics:
- ./golden_metrics.yml
summaryMetrics:
- ./summary_metrics.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @thezackm I've sent a couple of suggestions that will make this mergeable. Adding to those, we just need to change the directory to ext-unix_host
to match the new domain.
Thanks!
Co-authored-by: Galo Navarro <gnavarro@newrelic.com>
Co-authored-by: Galo Navarro <gnavarro@newrelic.com>
…unix_host/definition.yml
…ext-unix_host/golden_metrics.yml
…/ext-unix_host/summary_metrics.yml
query: | ||
select: max(percentUsed) | ||
from: '`unixMonitor:Disk`' | ||
facet: hostname, mountedOn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srvaroa - is multi-facet supported on golden metrics yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naxhh you're more up to date than me on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thezackm We support this in the definition but is still not being used in Golden metrics (WIP)
So when this is implemented this will convert into: FACET entity.name, hostname, mountedOn
Since you are using hostname as the entity.name
you probably want this to look like:
facet: mountedOn
the facet field is now "extra facets" in the same way we use "where" as extra where aside of entity.guid IN ....
hope that makes sense!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect; I'm good with the changes and ready to go; thanks for all the support!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, that's right @naxhh ! I forgot about that change since this branch was first made; let me take one last look through the golden and summary to validate things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok; ready to merge
@sschwartzman has mentioned we will want to look at a dashboard later, but that can be added outside of this workflow
Merging, as the CLA bot is broken but it's already signed. Thanks a lot for the contribution and patience! |
Relevant information
Adding entity for Unix On-Host Integration
Checklist
identifier
will be unique and valid.opening this PR.
explanation above.