Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support alternate method of having a "web" transaction #19

Closed
Ewan-GrandSlam opened this issue Oct 20, 2016 · 7 comments
Closed

Support alternate method of having a "web" transaction #19

Ewan-GrandSlam opened this issue Oct 20, 2016 · 7 comments

Comments

@Ewan-GrandSlam
Copy link

In using this new-relic agent, I am only able to use an http.X type to classify a request as an http or web request - however, due not using the standard net/http library I am only able to track my transactions as "background" requests - which is alright however does not accurately reflect what the data is actually doing.

As an example if I use a framework such as fasthttp where it is essentially io.writer and io.reader - I am unable to create a web transaction with the current agent - although I may have all the data needed to send a web transaction.

@willnewrelic
Copy link

Hi Ewan-GrandSlam

Thanks for the idea. I'm going to leave this open and add the "track-interest" label. I encourage all who would like this change to add a comment or thumbs up.

@kmhosny
Copy link

kmhosny commented Feb 4, 2017

Hi there,

is there any update on how to track web transactions when using the non standard net/http such as fasthttp? what kind of information does the go-agent extract from http.Response and http.Request may be i can populate it by hand?

thanks

@willnewrelic
Copy link

Hi

Thanks for all the interest. I will investigate fasthttp.

You can turn a background transaction into a web transaction by providing an empty http.Request as a parameter to StartTransaction:

txn := app.StartTransaction("notBackground", nil, &http.Request{})

@greenboxal
Copy link

I have interest in this as well. I'll start a PR changing the way the library treats http requests to use generic interfaces that can be implemented by anyone. So in case of anyone using fasthttp (my case), it will be just a matter of implementing the correct interface on top of it.

@greenboxal
Copy link

@kmhosny In case you need it, I just pushed https://github.com/greenboxal/nr-fasthttp. It depends on #56.

@ghost
Copy link

ghost commented Oct 5, 2017

Thanks to everyone for highlighting this issue! @Ewan-GrandSlam @kmhosny @greenboxal

This resulted in us opening a feature request to further look into the problem. We'll also take your PR into consideration @greenboxal !

I'm going to close this issue since we'll be tracking it internally. At this time I do not have an ETA when to expect this fix.

@willnewrelic
Copy link

We are going to do this!

Your feedback wanted:

#19

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants