Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AWS SDK v2 Integration Errors #250

Closed
RichVanderwal opened this issue Dec 3, 2020 · 3 comments · Fixed by #309
Closed

Fix AWS SDK v2 Integration Errors #250

RichVanderwal opened this issue Dec 3, 2020 · 3 comments · Fixed by #309
Assignees
@RichVanderwal
Labels
p2 Priority 2 work items
Projects
Go Engineering Board
Milestone
May Go Agent Release

Comments

@RichVanderwal
Copy link
Contributor

The CI checks for the Go Agent are failing when running tests about AWS SDK v2, expecting a github.com/aws/aws-sdk-go-v2/private/protocol/rest package that doesn't exist.

Fix or disable these tests.
@RichVanderwal RichVanderwal created this issue from a note in Go Engineering Board (To Do) Dec 3, 2020
@RichVanderwal RichVanderwal added the p2 Priority 2 work items label Dec 3, 2020
@jodeev jodeev added this to the Mar Go agent release milestone Mar 11, 2021
@RichVanderwal
Copy link
Contributor Author

Customer mentioned this in #250.

@RichVanderwal RichVanderwal mentioned this issue Mar 29, 2021
Closed
@RichVanderwal RichVanderwal moved this from To Do to In progress in Go Engineering Board May 3, 2021
@RichVanderwal
Copy link
Contributor Author

This has required a rewrite of the AWS SDK V2. We have a working version, and will issue a PR soon.

@RichVanderwal RichVanderwal moved this from In progress to Done in Go Engineering Board May 11, 2021
@RichVanderwal RichVanderwal self-assigned this May 11, 2021
@RichVanderwal RichVanderwal linked a pull request May 11, 2021 that will close this issue
New AWS SDK V2 integration #309
Merged
@RichVanderwal
Copy link
Contributor Author

Fixed in the May Go Agent Release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RichVanderwal RichVanderwal

Labels
p2 Priority 2 work items
Projects
Go Engineering Board
Done
Milestone
May Go Agent Release
Development

Successfully merging a pull request may close this issue.

New AWS SDK V2 integration RichVanderwal/go-agent
2 participants
@RichVanderwal @jodeev