Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release the Go agent v3.10.0 #261

Closed
RichVanderwal opened this issue Jan 7, 2021 · 5 comments · Fixed by #263
Closed

Release the Go agent v3.10.0 #261

RichVanderwal opened this issue Jan 7, 2021 · 5 comments · Fixed by #263
Assignees

Comments

@RichVanderwal
Copy link
Contributor

RichVanderwal commented Jan 7, 2021

Add IMDSv2 compatibility, an Open Source policy linter in GitHub Actions, and README.md fixes.

@RichVanderwal RichVanderwal created this issue from a note in Go Engineering Board (In progress) Jan 7, 2021
@RichVanderwal RichVanderwal self-assigned this Jan 7, 2021
@RichVanderwal
Copy link
Contributor Author

RichVanderwal commented Jan 7, 2021

Contains these PRs:

Amazon IMDSv2 compatibility from Rich Vanderwal (@RichVanderwal);
#249

License file changes to enable pkg.go.dev documentation from Ty Davis (@tydavis):
#254

Technical support plan header (Community Plus) from Melissa Klein (@melissaklein24):
#255

Readme spacing changes from Steve Willoughby (@nr-swilloughby):
#260

Repolinter from Joel Worrall (@tangollama )of the Open Source Program Office:
#262

@RichVanderwal RichVanderwal linked a pull request Jan 8, 2021 that will close this issue
@RichVanderwal
Copy link
Contributor Author

Agent and new functionality was smoke-tested in six scenarios. In each case, AWS IMDSv2 was showing AWS instance data when run in AWS, but not when run locally. Data was reported to the UI in each instance.

  • Staging
    -- Local Mac
    -- AWS Instance
  • Production
    -- Local Mac
    -- AWS Instance
  • EU
    -- Local Mac
    -- AWS Instance

@RichVanderwal
Copy link
Contributor Author

Benchmark testing on Rich's 2019 16" MacBook Pro:

?   	github.com/newrelic/go-agent/v3/examples/client	[no test files]
?   	github.com/newrelic/go-agent/v3/examples/custom-instrumentation	[no test files]
?   	github.com/newrelic/go-agent/v3/examples/server	[no test files]
?   	github.com/newrelic/go-agent/v3/examples/server-http	[no test files]
?   	github.com/newrelic/go-agent/v3/examples/short-lived-process	[no test files]
?   	github.com/newrelic/go-agent/v3/integrations/logcontext	[no test files]
PASS
ok  	github.com/newrelic/go-agent/v3/integrations/nrb3	0.450s
goos: darwin
goarch: amd64
pkg: github.com/newrelic/go-agent/v3/internal
BenchmarkDefaultRules-12        	  767786	      1518 ns/op	     113 B/op	       4 allocs/op
BenchmarkSegmentTerms-12        	 2322117	       505 ns/op	     128 B/op	       3 allocs/op
BenchmarkTraceIDGenerator-12    	13876485	        87.5 ns/op	      32 B/op	       2 allocs/op
PASS
ok  	github.com/newrelic/go-agent/v3/internal	5.484s
PASS
ok  	github.com/newrelic/go-agent/v3/internal/awssupport	0.512s
PASS
ok  	github.com/newrelic/go-agent/v3/internal/cat	1.393s
?   	github.com/newrelic/go-agent/v3/internal/com_newrelic_trace_v1	[no test files]
?   	github.com/newrelic/go-agent/v3/internal/crossagent	[no test files]
PASS
ok  	github.com/newrelic/go-agent/v3/internal/integrationsupport	0.331s
PASS
ok  	github.com/newrelic/go-agent/v3/internal/jsonx	1.341s
?   	github.com/newrelic/go-agent/v3/internal/logger	[no test files]
?   	github.com/newrelic/go-agent/v3/internal/stacktracetest	[no test files]
PASS
ok  	github.com/newrelic/go-agent/v3/internal/sysinfo	1.331s
?   	github.com/newrelic/go-agent/v3/internal/tools/interface-wrapping	[no test files]
?   	github.com/newrelic/go-agent/v3/internal/tools/rules	[no test files]
?   	github.com/newrelic/go-agent/v3/internal/tools/utilization	[no test files]
PASS
ok  	github.com/newrelic/go-agent/v3/internal/utilization	1.346s
goos: darwin
goarch: amd64
pkg: github.com/newrelic/go-agent/v3/newrelic
BenchmarkTxnEventsCollectorJSON-12              	     147	   8017496 ns/op	 7364203 B/op	   68633 allocs/op
BenchmarkCustomEventsCollectorJSON-12           	     238	   5180138 ns/op	 5639692 B/op	   43970 allocs/op
BenchmarkErrorEventsCollectorJSON-12            	     182	   6636472 ns/op	 6556424 B/op	   56585 allocs/op
BenchmarkAgentAttributes-12                     	  275144	      4558 ns/op	    4418 B/op	      43 allocs/op
BenchmarkPayloadText-12                         	  483283	      2327 ns/op	    1834 B/op	      26 allocs/op
BenchmarkAcceptW3C-12                           	  379340	      2810 ns/op	    2685 B/op	      36 allocs/op
BenchmarkErrorsJSON-12                          	   60825	     20353 ns/op	   31324 B/op	     155 allocs/op
BenchmarkMuxWithoutNewRelic-12                  	 7295976	       146 ns/op	     110 B/op	       1 allocs/op
BenchmarkMuxWithNewRelic-12                     	  180679	      6108 ns/op	    6930 B/op	      68 allocs/op
BenchmarkTraceSegmentWithDefer-12               	 2839653	       386 ns/op	     284 B/op	       4 allocs/op
BenchmarkTraceSegmentNoDefer-12                 	 3386338	       317 ns/op	     198 B/op	       2 allocs/op
BenchmarkTraceSegmentZeroSegmentThreshold-12    	 2761885	       424 ns/op	     276 B/op	       4 allocs/op
BenchmarkDatastoreSegment-12                    	 1367823	       815 ns/op	     712 B/op	      13 allocs/op
BenchmarkExternalSegment-12                     	 1603021	       818 ns/op	     609 B/op	       7 allocs/op
BenchmarkTxnWithSegment-12                      	  446293	      2945 ns/op	    3402 B/op	      33 allocs/op
BenchmarkTxnWithDatastore-12                    	  288352	      4681 ns/op	    4900 B/op	      50 allocs/op
BenchmarkTxnWithExternal-12                     	  297013	      3891 ns/op	    4641 B/op	      42 allocs/op
BenchmarkBrowserTimingHeaderSuccess-12          	  347634	      3597 ns/op	    3544 B/op	      42 allocs/op
BenchmarkMetricTableCollectorJSON-12            	    1106	   1045090 ns/op	  934685 B/op	    8561 allocs/op
BenchmarkAddingSameMetrics-12                   	12704554	        90.1 ns/op	      58 B/op	       0 allocs/op
BenchmarkServerless-12                          	    3228	    368797 ns/op	 1462103 B/op	    1829 allocs/op
BenchmarkWitnessNode-12                         	 8978030	       114 ns/op	      76 B/op	       0 allocs/op
PASS
ok  	github.com/newrelic/go-agent/v3/newrelic	44.598s
PASS
ok  	github.com/newrelic/go-agent/v3/newrelic/sqlparse	0.311s

@tydavis
Copy link
Contributor

tydavis commented Jan 11, 2021

Looks great - waiting for a tagged release to update pkg.go.dev

Forced update is possible once the tagged version is released by running:

curl https://sum.golang.org/lookup/github.com/newrelic/go-agent/v3@v3.10.0

@nr-swilloughby nr-swilloughby moved this from In progress to Done in Go Engineering Board Jan 12, 2021
@Ak-x
Copy link

Ak-x commented Sep 8, 2021

Closing this issue as Go Agent 3.10.0 has been released.

@Ak-x Ak-x closed this as completed Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants