Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme fix #260

Merged
merged 2 commits into from
Jan 6, 2021
Merged

Readme fix #260

merged 2 commits into from
Jan 6, 2021

Conversation

nr-swilloughby
Copy link
Contributor

Adjusted README file to remove extraneous spaces in the paragraphs.

@CLAassistant
Copy link

CLAassistant commented Jan 5, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

RichVanderwal
RichVanderwal approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@RichVanderwal RichVanderwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will is a proponent of two spaces between sentences, and this brings it into line with the rest of New Relic's documentation. Thanks!

RichVanderwal
RichVanderwal suggested changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@RichVanderwal RichVanderwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make these changes against the develop branch, not master?

@nr-swilloughby nr-swilloughby changed the base branch from master to develop January 6, 2021 19:32
RichVanderwal
RichVanderwal approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@RichVanderwal RichVanderwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, develop is the right place for this. Thanks!

@nr-swilloughby nr-swilloughby merged commit 35ec4cf into newrelic:develop Jan 6, 2021
@RichVanderwal RichVanderwal mentioned this pull request Jan 7, 2021
Closed
@jodeev jodeev added this to Done in Go Engineering Board Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichVanderwal RichVanderwal RichVanderwal approved these changes

Assignees
No one assigned
Labels
ready-for-review
Projects
Go Engineering Board
Done
Roadmap
Awaiting triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nr-swilloughby @CLAassistant @RichVanderwal