Add stack frame lookup based on runtime.CallersFrames for supported g… #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o versions Fix loop Fix build tags
|
@lggomez Thank you for this work! It is coincidental timing, as your PR came in just as we finished up reviewing a PR internally that is very similar. That PR is about to be merged internally. One of my colleagues caught a bug in my code, which I think is also present in your code, where the last frame of the stack trace is missed because when We will be merging our internal PR shortly, and the fix will be included in the next agent release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work required for #100
Does not remove the dependency on runtime.Callers but it simplifies the implementation and removes the need for FuncForPC on Go 1.7+