Updates examples to retrieve transaction using FromContext #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kevburnsjr Thank you! We agree: This example code was written before Go 1.7. It is very old! We appreciate your contribution. Expect to see this in the next release. |
|
Hi @kevburnsjr We just released version 2.14.0 with this change! Thanks again for giving us this PR! |
Contributor
Author
Contributor
|
@kevburnsjr Thanks for finding those, they have been updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FromContextis the newer method for accessing a transaction from within an http handler.These examples use a mix of type casting and
FromContext. This PR makes them consistent.I propose that New Relic update all documentation and examples removing type casting in favor of
FromContextto help prevent customers from experiencing issues related to the old type cast method.Details regarding the type of problem type casting creates and why
FromContextis strictly superior can be found in the following github issue for a piece of HTTP middleware that is incompatible with many newrelic integrations due to the widespread use of type casting for transaction retrieval: kevburnsjr/microcache#10