Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for v8 of go-redis/redis #251

Merged
merged 1 commit into from Mar 17, 2021
Merged

Added support for v8 of go-redis/redis #251

merged 1 commit into from Mar 17, 2021

Conversation

ilmimris
Copy link
Contributor

@ilmimris ilmimris commented Dec 3, 2020

Links

Working on support go-redis/redis/v8

Details

  • Update version redis to go-redis/redis/v8
  • Fix compatibility code example and test with go-redis/redis/v8

@CLAassistant
Copy link

CLAassistant commented Dec 3, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@ilmimris ilmimris mentioned this pull request Dec 3, 2020
Closed
@jodeev jodeev added this to To Do in Go Engineering Board Dec 17, 2020
@yang-wei
Copy link

yang-wei commented Feb 9, 2021

hi is anyone looking at this ?

@jodeev jodeev added p2 Priority 2 work items size labels Feb 25, 2021
@jodeev
Copy link
Contributor

jodeev commented Feb 25, 2021

Next steps: needs a rough estimate and we'll prioritize from there.

@jodeev jodeev added this to the Mar Go agent release milestone Mar 5, 2021
@RichVanderwal RichVanderwal self-assigned this Mar 17, 2021
RichVanderwal
RichVanderwal approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@RichVanderwal RichVanderwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @ilmimris, and thanks for helping us keep up to date with Redis!

Very few changes from v7 here -- getting context and it around to satisfy the new library requirements.

@RichVanderwal RichVanderwal moved this from To Do to In progress in Go Engineering Board Mar 17, 2021
@RichVanderwal RichVanderwal merged commit 5739767 into newrelic:master Mar 17, 2021
Go Engineering Board automation moved this from In progress to Done Mar 17, 2021
@RichVanderwal RichVanderwal mentioned this pull request Mar 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichVanderwal RichVanderwal RichVanderwal approved these changes

Assignees

@RichVanderwal RichVanderwal

Labels
p2 Priority 2 work items
Projects
Go Engineering Board
Done
Milestone
Mar Go agent release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ilmimris @CLAassistant @yang-wei @jodeev @RichVanderwal