Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nrecho test #509

Merged
merged 12 commits into from Jun 13, 2022
Merged

Nrecho test #509

merged 12 commits into from Jun 13, 2022

Conversation

mirackara
Copy link
Contributor

Details

Bumped go-version to 1.17.x

@CLAassistant
Copy link

CLAassistant commented Jun 2, 2022

CLA assistant check
All committers have signed the CLA.

@nr-swilloughby
Copy link
Contributor

Note that we never merge PRs into the master/main branch. This should be merged into develop and then a release PR (when we're ready for a release) is created to merge the new stuff in develop into master.

@iamemilio iamemilio changed the base branch from master to develop June 3, 2022 19:32
@iamemilio iamemilio linked an issue Jun 6, 2022 that may be closed by this pull request
@mirackara
Copy link
Contributor Author

Added additional attributes that are now required after distributed tracing update.

Note: nrecho-v4 tests pass locally but not on GitHub Actions due to changes to expect.go file. The tests will pass after bumping the version number in the nrecho-v4 mod file when a new version is released.

@mirackara mirackara marked this pull request as ready for review June 6, 2022 20:17
@iamemilio iamemilio merged commit 538508c into newrelic:develop Jun 13, 2022
@mirackara mirackara deleted the nrecho-test branch June 16, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Broken v3/nrecho-v4 test
4 participants