Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logrus Logs in Context Support #538

Merged
merged 5 commits into from
Jul 28, 2022

Conversation

iamemilio
Copy link
Contributor

@iamemilio iamemilio commented Jul 11, 2022

What this change adds

Logs in Context:

  • log decorating package usable by all packages

Logrus:

  • automatic log forwarding
  • log metrics
  • v2 log decorating

@iamemilio iamemilio changed the base branch from master to develop July 11, 2022 21:08
@iamemilio iamemilio force-pushed the logrus_plugin branch 2 times, most recently from a2ac33d to e0e9e0a Compare July 13, 2022 18:23
@iamemilio iamemilio marked this pull request as ready for review July 13, 2022 18:23
@iamemilio iamemilio changed the title Logrus plugin Logrus Logs in Context Support Jul 15, 2022
nr-swilloughby
nr-swilloughby previously approved these changes Jul 15, 2022
mirackara
mirackara previously approved these changes Jul 18, 2022
Copy link
Contributor

@mirackara mirackara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@iamemilio iamemilio dismissed stale reviews from mirackara and nr-swilloughby via fb1f105 July 21, 2022 17:46
@iamemilio iamemilio changed the title Logrus Logs in Context Support Logrus Logs in Context Support + Logging by Default Jul 21, 2022
@iamemilio
Copy link
Contributor Author

Finally verified this with the help of @bizob2828, thanks again. This is ready to merge

@bizob2828
Copy link
Member

Posting a screenshot of logs for posterity

screenshot 2022-07-22 at 11 14 13 AM

nr-swilloughby
nr-swilloughby previously approved these changes Jul 25, 2022
@iamemilio iamemilio changed the title Logrus Logs in Context Support + Logging by Default Logrus Logs in Context Support Jul 27, 2022
@nr-swilloughby nr-swilloughby merged commit 37da0f9 into newrelic:develop Jul 28, 2022
@ghost
Copy link

ghost commented Jul 29, 2022

Howdy! When is this feature going to be tagged/released?

@nr-swilloughby
Copy link
Contributor

It's in process for release next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants