[nr-k8s-otel-collector] Updates on README and chart values #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramkrishankumarN
approved these changes
May 15, 2024
|
|
||
| image: | ||
| # -- OTel collector image to be deployed. NRDOT is the default value but you can use your own collector as long it accomplish the following requirements |
There was a problem hiding this comment.
Should we also add what the following requirements are?
There was a problem hiding this comment.
I agree, that would be helpful
dbudziwojskiNR
requested changes
May 15, 2024
|
|
||
| image: | ||
| # -- OTel collector image to be deployed. NRDOT is the default value but you can use your own collector as long it accomplish the following requirements |
There was a problem hiding this comment.
I agree, that would be helpful
csongnr
reviewed
May 15, 2024
csongnr
reviewed
May 15, 2024
dbudziwojskiNR
approved these changes
May 16, 2024
dbudziwojskiNR
changed the title
Fix lint errors.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname])