[newrelic-infrastructure]: Make securityContext a templated value for windows infra daemonset #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goody44
requested review from
gsanchezgavier,
jorik and
paologallinaharbur
as code owners
|
|
|
Thanks @goody44 for the contribution. It looks good, I will proceed to merge it once license agreements are signed, Can you also rebase on master? |
paologallinaharbur
approved these changes
Nov 9, 2020
|
Thanks for the review! I've signed the CLA and rebased, although I may have messed that up as the diff is now showing the re-based changes? |
|
There are different way to solve this issue. I would suggest to rebase using the interactive mode over the updated fork
Or you can reopen the PR copying manually the changes |
|
Sorry for the delay and thanks for the instructions. I've rebased it properly now |
paologallinaharbur
approved these changes
Nov 24, 2020
cleon-nr
pushed a commit
that referenced
this pull request
Jan 21, 2021
* [nri-bundle] Updates newrelic-logging in nri-bundle to version 1.4.0 (#206) * [LOGGING-3818] Updates newrelic-logging in nri-bundle to version 1.4.0 * [newrelic-infrastructure] use k8s integration 1.26.8 (#207) * [nri-bundle] bumping version newrelic-infrastacture (#208) * cert-manager support for webhook (#173) * [newrelic-infrastructure]: Make securityContext a templated value for windows infra daemonset (#174) * Make securityContext a templated value for windows infra daemonset * Bumped chart version * Update Chart.yaml Co-authored-by: PaoloGallina <43335750+paologallinaharbur@users.noreply.github.com> * feat(nri-bundle): newrelic-infra and metadata-injection (#212) * Adding back the escaped decoder to the docker json format (#214) * [newrelic-logging] Documentation for proxy support (#215) * Documentation for proxy support * [nri-bundle] Update newrelic-logging in nri-bundle to version 1.4.2 (#216) * Update newrelic-logging in nri-bundle to version 1.4.1 * [nri-prometheus] Add podAnnotation support (#221) * [nri-metadata-injection] Add podAnnotation support (#220) Co-authored-by: Antonio Dias <adias@newrelic.com> * [charts/newrelic-infrastructure] Fix and cleanup readme (#217) Co-authored-by: PaoloGallina <43335750+paologallinaharbur@users.noreply.github.com> * [nri-kube-events] Add podAnnotations support (#219) Co-authored-by: Antonio Dias <adias@newrelic.com> Co-authored-by: PaoloGallina <43335750+paologallinaharbur@users.noreply.github.com> Co-authored-by: jsubirat <jsubirat@users.noreply.github.com> Co-authored-by: Guillermo Sanchez Gavier <gsanchez@newrelic.com> Co-authored-by: Adam Graves <adam.graves85@gmail.com> Co-authored-by: Matthew Goodson <goody44@users.noreply.github.com> Co-authored-by: PaoloGallina <43335750+paologallinaharbur@users.noreply.github.com> Co-authored-by: Edmo Vamerlatti Costa <edinhow@gmail.com> Co-authored-by: Teotonio da Silva Paranhos Junior <te_junior@yahoo.com.br> Co-authored-by: Marcus Noble <m.noble@elsevier.com> Co-authored-by: Antonio Dias <adias@newrelic.com> Co-authored-by: 20201020_Synthetics_Team <team_proactive-monitoring@newrelic.com>
cleon-nr
pushed a commit
that referenced
this pull request
Jan 21, 2021
…9 and appVersion to 3.0.31 (#16) * [nri-bundle] Updates newrelic-logging in nri-bundle to version 1.4.0 (#206) * [LOGGING-3818] Updates newrelic-logging in nri-bundle to version 1.4.0 * [newrelic-infrastructure] use k8s integration 1.26.8 (#207) * [nri-bundle] bumping version newrelic-infrastacture (#208) * cert-manager support for webhook (#173) * [newrelic-infrastructure]: Make securityContext a templated value for windows infra daemonset (#174) * Make securityContext a templated value for windows infra daemonset * Bumped chart version * Update Chart.yaml Co-authored-by: PaoloGallina <43335750+paologallinaharbur@users.noreply.github.com> * feat(nri-bundle): newrelic-infra and metadata-injection (#212) * Adding back the escaped decoder to the docker json format (#214) * [newrelic-logging] Documentation for proxy support (#215) * Documentation for proxy support * [nri-bundle] Update newrelic-logging in nri-bundle to version 1.4.2 (#216) * Update newrelic-logging in nri-bundle to version 1.4.1 * [nri-prometheus] Add podAnnotation support (#221) * [nri-metadata-injection] Add podAnnotation support (#220) Co-authored-by: Antonio Dias <adias@newrelic.com> * [charts/newrelic-infrastructure] Fix and cleanup readme (#217) Co-authored-by: PaoloGallina <43335750+paologallinaharbur@users.noreply.github.com> * [nri-kube-events] Add podAnnotations support (#219) Co-authored-by: Antonio Dias <adias@newrelic.com> Co-authored-by: PaoloGallina <43335750+paologallinaharbur@users.noreply.github.com> * [charts/synthetics-minion] Automatically bumped chartVersion to 1.0.19 and appVersion to 3.0.31 Co-authored-by: jsubirat <jsubirat@users.noreply.github.com> Co-authored-by: Guillermo Sanchez Gavier <gsanchez@newrelic.com> Co-authored-by: Adam Graves <adam.graves85@gmail.com> Co-authored-by: Matthew Goodson <goody44@users.noreply.github.com> Co-authored-by: PaoloGallina <43335750+paologallinaharbur@users.noreply.github.com> Co-authored-by: Edmo Vamerlatti Costa <edinhow@gmail.com> Co-authored-by: Teotonio da Silva Paranhos Junior <te_junior@yahoo.com.br> Co-authored-by: Marcus Noble <m.noble@elsevier.com> Co-authored-by: Antonio Dias <adias@newrelic.com> Co-authored-by: nr-opensource-bot <nr-opensource-bot@users.noreply.github.com> Co-authored-by: 20201020_Synthetics_Team <team_proactive-monitoring@newrelic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart
No
What this PR does / why we need it:
Deploying the Windows infra chart to GKE results in the error below. If the
spec.containers[0].securityContextvalue is removed then it works fine. This PR makes the securityContext field a templated value.(combined from similar events): Error creating: admission webhook "windows.common-webhooks.networking.gke.io" denied the request: spec.containers[0].securityContext: Invalid value: v1.SecurityContext{Capabilities:(*v1.Capabilities)(nil), Privileged:(*bool)(0xc000696a3c), SELinuxOptions:(*v1.SELinuxOptions)(nil), RunAsUser:(*int64)(nil), RunAsGroup:(*int64)(nil), RunAsNonRoot:(*bool)(nil), ReadOnlyRootFilesystem:(*bool)(nil), AllowPrivilegeEscalation:(*bool)(nil), ProcMount:(*v1.ProcMountType)(nil)}: Windows does not support this field. Note that defaults may be allowed for compatibility.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname])