[CI/CD] Fix pipeline to add missing origin #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
| @@ -16,6 +16,7 @@ chart-dirs: | |||
|
|
|||
| chart-repos: | |||
| - newrelic-helm-charts=https://newrelic.github.io/helm-charts | |||
| - newrelic-cdn-helm-charts=https://helm-charts.newrelic.com | |||
There was a problem hiding this comment.
i didn't get why this is need, out of curiosity what is newrelic-cdn-helm-charts ?
There was a problem hiding this comment.
Is the same as https://newrelic.github.io/helm-charts but behind a CDN controlled by CnC team.
% curl -v https://helm-charts.newrelic.com/index.yaml
* Trying 2600:9000:2340:ea00:14:72f:c200:93a1:443...
* Connected to helm-charts.newrelic.com (2600:9000:2340:ea00:14:72f:c200:93a1) port 443 (#0)
* ALPN, offering h2
[...]
* SSL certificate verify ok.
* Connection state changed (HTTP/2 confirmed)
> GET /index.yaml HTTP/2
> Host: helm-charts.newrelic.com
> user-agent: curl/7.79.1
> accept: */*
>
* Connection state changed (MAX_CONCURRENT_STREAMS == 128)!
< HTTP/2 302
< content-length: 0
< location: https://newrelic.github.io/helm-charts/index.yaml
< server: CloudFront
< x-amz-cf-id: bl5GbNKLxqFwMAvKeDXwyX4fstYSNc4OCEEBKY1HtHXLOmH8TLjSag==
< age: 11
<
It is needed because in all the docs we point to that domain instead of https://newrelic.github.io/helm-charts. One contributor pipeline is failing because he is using that URL.
There was a problem hiding this comment.
gsanchezgavier
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart
No
What this PR does / why we need it:
Fix pipeline to add missing helm chart origin. Tests are failing on the PR #762. This change should fix it.
Checklist
[mychartname])