Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nri-bundle] removing collector to address noisy log #832

Merged
merged 2 commits into from
May 24, 2022

Conversation

paologallinaharbur
Copy link
Member

Is this a new chart

no

What this PR does / why we need it:

In order to remove an annoying log from KSM:

I0524 07:33:23.082532       1 builder.go:146] Active collectors: certificatesigningrequests,configmaps,cronjobs,daemonsets,deployments,endpoints,horizontalpodautoscalers,ingresses,jobs,limitranges,mutatingwebhookconfigurations,namespaces,networkpolicies,nodes,persistentvolumeclaims,persistentvolumes,poddisruptionbudgets,pods,replicasets,replicationcontrollers,resourcequotas,secrets,services,statefulsets,storageclasses,validatingwebhookconfigurations,volumeattachments
E0524 07:33:23.150180       1 reflector.go:156] pkg/mod/k8s.io/client-go@v0.0.0-20191109102209-3c0d1af94be5/tools/cache/reflector.go:108: Failed to list *v1beta1.CertificateSigningRequest: the server could not find the requested resource
E0524 07:33:23.165645       1 reflector.go:156] pkg/mod/k8s.io/client-go@v0.0.0-20191109102209-3c0d1af94be5/tools/cache/reflector.go:108: Failed to list *v1beta1.Ingress: the server could not find the requested resource (get ingresses.extensions)
E0524 07:33:24.159165       1 reflector.go:156] pkg/mod/k8s.io/client-go@v0.0.0-20191109102209-3c0d1af94be5/tools/cache/reflector.go:108: Failed to list *v1beta1.CertificateSigningRequest: the server could not find the requested resource

Which issue this PR fixes

fix #582

Special notes for your reviewer:

Superseeds #604

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [mychartname])

@paologallinaharbur paologallinaharbur requested a review from a team as a code owner May 24, 2022 07:39
Copy link
Contributor

@kang-makes kang-makes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With that NIT I think the README would be nicer.

charts/nri-bundle/values.yaml Outdated Show resolved Hide resolved
@paologallinaharbur paologallinaharbur merged commit a9e6d9d into master May 24, 2022
@paologallinaharbur paologallinaharbur deleted the feat/ksmLogs branch May 24, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nri-bundle] KSM creates noisy logs in Kubernetes 1.22
3 participants