Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added regex handling for passthrough env #1060

Merged
merged 1 commit into from
Mar 30, 2022
Merged

added regex handling for passthrough env #1060

merged 1 commit into from
Mar 30, 2022

Conversation

brushknight
Copy link
Contributor

@brushknight brushknight commented Mar 30, 2022 •
edited
Loading

Allowing to use regex for passthrough_environment
Example

passthrough_environment:
  - HOME
  - SUDO.*

Will add HOME and all SUDO* variables into passthrough

rubenruizdegauna
rubenruizdegauna approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@rubenruizdegauna rubenruizdegauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rogercoll
rogercoll approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@rogercoll rogercoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@brushknight brushknight merged commit b4bb7fb into master Mar 30, 2022
@brushknight brushknight deleted the passthrough_env_regex branch March 30, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenruizdegauna rubenruizdegauna rubenruizdegauna approved these changes

@rogercoll rogercoll rogercoll approved these changes

@cristianciutea cristianciutea Awaiting requested review from cristianciutea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brushknight @rubenruizdegauna @rogercoll