Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cciutea/msi change #1635

Merged
merged 7 commits into from May 29, 2023
Merged

Cciutea/msi change #1635

merged 7 commits into from May 29, 2023

Conversation

cristianciutea
Copy link
Contributor

This PR will add additional check for symlink in msi installer for the main directory

@cristianciutea cristianciutea requested a review from a team as a code owner April 27, 2023 08:41
ExeCommand="cmd /C "dir /al /s "[NewRelicInfraDataFolder]." >nul 2>&1 " && (EXIT /B 1) || (EXIT /B 0)"
<CustomAction Id="CheckSymlinksCommonAppDataFolder"
Directory="CommonAppDataFolder"
ExeCommand="cmd /C &quot;dir /al &quot;[CommonAppDataFolder]New Relic*&quot; >nul 2>&amp;1 &quot; &amp;&amp; (EXIT /B 1) || (EXIT /B 0)"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check for the main directory without subdirectories

Copy link
Contributor

@rubenruizdegauna rubenruizdegauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rubenruizdegauna rubenruizdegauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cristianciutea cristianciutea merged commit 2cadc8d into master May 29, 2023
21 of 23 checks passed
@cristianciutea cristianciutea deleted the cciutea/msi_change branch May 29, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants