New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cciutea/msi change #1635
Cciutea/msi change #1635
Conversation
ExeCommand="cmd /C "dir /al /s "[NewRelicInfraDataFolder]." >nul 2>&1 " && (EXIT /B 1) || (EXIT /B 0)" | ||
<CustomAction Id="CheckSymlinksCommonAppDataFolder" | ||
Directory="CommonAppDataFolder" | ||
ExeCommand="cmd /C "dir /al "[CommonAppDataFolder]New Relic*" >nul 2>&1 " && (EXIT /B 1) || (EXIT /B 0)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check for the main directory without subdirectories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR will add additional check for symlink in msi installer for the main directory