Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NR-181605 Add sendMetrics param to newrelic output plugin in FB conf file #1759

Merged

Conversation

Sivakumar3695
Copy link
Contributor

@Sivakumar3695 Sivakumar3695 commented Nov 29, 2023

Issue link: NR-181605

Description

  • For log forwarding, a new param - sendMetrics is introduced in the newrelic-fluent-bit-output plugin.
  • While constructing the FluentBit config file, the output plugin should contain sendMetrics param if verbose logging is enabled for supervisor via log_filter in the newrelic-infra.yml file.

Changes

  • the new param is introduced in the template file
  • from config/config.go LogForward, verbose logging mode is checked and set to this field - FluentBitVerbose
  • The above FluentBitVerbose field is used to check if sendMetrics param should be in fluentBit config file.

Test cases

  • Test cases for the new changes are added in cfg_test.go and loader_test.go

@Sivakumar3695 Sivakumar3695 marked this pull request as ready for review November 29, 2023 09:00
@Sivakumar3695 Sivakumar3695 requested a review from a team as a code owner November 29, 2023 09:00
@Sivakumar3695 Sivakumar3695 changed the title NR-181605 Logging send metrics NR-181605 Add sendMetrics param to newrelic output plugin in FB conf file Nov 29, 2023
Copy link
Contributor

@danybmx danybmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇🏻 All good!

Copy link
Contributor

@rubenruizdegauna rubenruizdegauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but commits need to be signed @Sivakumar3695 (https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits)

Can you sign them and push force?

Thanks

Copy link
Contributor

@rubenruizdegauna rubenruizdegauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rubenruizdegauna rubenruizdegauna merged commit 9fb4b9a into newrelic:master Dec 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants