Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parser for integration SDK errors #1800

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

alvarocabanas
Copy link
Contributor

@alvarocabanas alvarocabanas commented Feb 1, 2024

The infrastructure agent will now log integration execution errors matching the level set for infra-agent logs.
Before this fix, all integrations logs were output only when the infra-agent level was debug. The integrations warning and info level logs will continue being output only when the agent level is debug.

The infrastructure agent is also capable of filtering the errors of an integration if it's explicitly defined in the log configuration. In this example the errors coming from nri-mssql won't be shown when the agent log is in any level (except debug):

log:
  exclude_filters:
    integration_name:
      - nri-mssql

@alvarocabanas alvarocabanas requested a review from a team as a code owner February 1, 2024 11:01
@alvarocabanas alvarocabanas force-pushed the NR-171671_support_sdk_log_parsing branch 2 times, most recently from aeee865 to 8fe7181 Compare February 1, 2024 15:47
@alvarocabanas alvarocabanas requested a review from a team February 1, 2024 15:49
@alvarocabanas alvarocabanas force-pushed the NR-171671_support_sdk_log_parsing branch 4 times, most recently from 3c44b30 to e81af00 Compare February 1, 2024 16:17
@alvarocabanas alvarocabanas force-pushed the NR-171671_support_sdk_log_parsing branch from e81af00 to f1dc640 Compare February 2, 2024 12:23
@alvarocabanas alvarocabanas force-pushed the NR-171671_support_sdk_log_parsing branch from f1dc640 to b04608c Compare February 2, 2024 13:19
Copy link
Contributor

@gsanchezgavier gsanchezgavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would add a more descriptive PR description to understand the consequences of the change.

@alvarocabanas alvarocabanas force-pushed the NR-171671_support_sdk_log_parsing branch 4 times, most recently from 1f7ac48 to 641adbf Compare February 5, 2024 11:43
DavSanchez
DavSanchez previously approved these changes Feb 5, 2024
Copy link
Contributor

@DavSanchez DavSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@alvarocabanas alvarocabanas force-pushed the NR-171671_support_sdk_log_parsing branch 3 times, most recently from d619854 to 232ce81 Compare February 5, 2024 12:16
DavSanchez
DavSanchez previously approved these changes Feb 5, 2024
Copy link
Contributor

@DavSanchez DavSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@alvarocabanas alvarocabanas merged commit 01752cc into master Feb 5, 2024
23 checks passed
@alvarocabanas alvarocabanas deleted the NR-171671_support_sdk_log_parsing branch February 5, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants