NR-234856 Wrapped attribute key and value in double quotes #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sivakumar3695
force-pushed
the
NR-234856-logging-attribute-fix
branch
from
daf7728
to
966d6d5
Compare
jsubirat
reviewed
Mar 11, 2024
There was a problem hiding this comment.
Hey @Sivakumar3695 , great work! I requested the inclusion of a couple of tests to check the YAML -> struct conversion. Great work so far!
| "fb.input": "tail", | ||
| "key1": "value1", | ||
| "key2": "value2", | ||
| "key3 with space": "value3 with space", |
There was a problem hiding this comment.
Doing a quick check, it seems that if you specify an attribute with spaces in its name, YAML actually accepts it:
I didn't expect that!
Could you please introduce a test here that checks the YAML -> struct conversion, both when having attribute names with whitespaces and attributes values with whitespaces?
There was a problem hiding this comment.
Hi @jsubirat, Nice suggestion.
A Test case has been added to check if attribute key and value with spaces are working. Thank you!
jsubirat
approved these changes
Mar 13, 2024
| "fb.input": "tail", | ||
| "key1": "value1", | ||
| "key2": "value2", | ||
| "key3 with space": "value3 with space", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For logging, to allow spaces between attribute key and value, the corresponding values are wrapped inside double quotes.
Testing screenshot:
