Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NR-279356: Add new multiline parser config param to logging config #1881

Conversation

SivaKumarP127
Copy link
Contributor

@SivaKumarP127 SivaKumarP127 commented Jun 14, 2024

Description

Adds a new config parameter which is Multiline.Parser to the INPUT block of fluent-bit config which enables the user to parse multiline logs. And this can be enabled by configuring the multilineParser for the log file in the logging.yml like below.

logging.yml 

 -  name: java.log
    file: /var/log/javalogs.log
    multilineParser: java
    attributes:
      logtype: java_logs
fluent-bit.conf

[INPUT]
    Name tail
    Path /var/log/javalogs.log
    Buffer_Max_Size 128k
    Mem_Buf_Limit 16384k
    Skip_Long_Lines On
    Multiline.Parser java        
    Path_Key filePath
    Tag  java.log
    DB   /var/db/newrelic-infra/newrelic-integrations/logging/fb.db

Note: Fluent-Bit already has built-in multiline parsers which are java, go, python, docker and cri. And the above changes will only support fluent-bit built-in multiline parsers.
FYI: https://docs.fluentbit.io/manual/administration/configuring-fluent-bit/multiline-parsing#built-in-multiline-parsers

@SivaKumarP127 SivaKumarP127 marked this pull request as ready for review June 14, 2024 04:35
@SivaKumarP127 SivaKumarP127 requested a review from a team as a code owner June 14, 2024 04:35
Copy link
Contributor

@rubenruizdegauna rubenruizdegauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rubenruizdegauna
Copy link
Contributor

@SivaKumarP127 can you sign the commits please? Thanks!

@SivaKumarP127 SivaKumarP127 force-pushed the NR-279356_Add-multiline-parser-param branch from e85b83e to dcb7440 Compare June 14, 2024 13:12
@rubenruizdegauna rubenruizdegauna merged commit 4cacb5c into newrelic:master Jun 14, 2024
5 checks passed
@SivaKumarP127
Copy link
Contributor Author

Hi @rubenruizdegauna. Could you please let me know when these changes will be released?
Thank you!

@rubenruizdegauna
Copy link
Contributor

Hi @SivaKumarP127 , the idea is to create a release with that change this week. So let's think that next week should be already released.

@rubenruizdegauna
Copy link
Contributor

Hi @SivaKumarP127 , yesterday we did a release that contains this functionality

https://github.com/newrelic/infrastructure-agent/releases/tag/1.53.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants