Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove event fields exclusion #224

Merged
merged 10 commits into from
Nov 27, 2020
Merged

feat: remove event fields exclusion #224

merged 10 commits into from
Nov 27, 2020

Conversation

varas
Copy link
Contributor

@varas varas commented Nov 12, 2020 •
edited
Loading

This increases current events keys storage which is limited to a fixed set of field names.
Behaviour before this was:

  • every field non included in the previous "inclusion list" gets discarded.
    Behaviour now:
  • only fields within a "exclusion list" are discarded.

@varas varas requested a review from a team November 12, 2020 16:29
@varas varas force-pushed the feat_remove-event-fields-exclusion branch from 0247589 to 55c3cb2 Compare November 12, 2020 18:25
@coveralls
Copy link

Pull Request Test Coverage Report for Build 360226753

  • 13 of 13 (100.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 58.234%
Files with Coverage Reduction New Missed Lines %
internal/agent/event_sender.go 1 72.56%
Totals Coverage Status
Change from base Build 359833315: 0.02%
Covered Lines: 11235
Relevant Lines: 19293
💛 - Coveralls

noly
noly previously approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@noly noly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good!!
Could you add some description/context about the change? It help us to write better release notes. TY

carlosroman
carlosroman previously approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@carlosroman carlosroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@varas @carlosroman
Copyright
0200fec 
Co-authored-by: Carlos <croman@newrelic.com>
@varas @carlosroman
Copyright
8f2799a 
Co-authored-by: Carlos <croman@newrelic.com>
@josemore josemore added this to Ready for review in CAOS: Our Daily Bread Nov 25, 2020
cristianciutea
cristianciutea approved these changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@cristianciutea cristianciutea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlosroman carlosroman merged commit 00ac7ef into master Nov 27, 2020
@carlosroman carlosroman deleted the feat_remove-event-fields-exclusion branch November 27, 2020 09:21
@brushknight brushknight moved this from Ready for review to Ready For Release in CAOS: Our Daily Bread Nov 27, 2020
@josemore josemore moved this from Ready For Release to Done in CAOS: Our Daily Bread Dec 9, 2020
@josemore josemore moved this from Done to Ready For Release in CAOS: Our Daily Bread Dec 9, 2020
@josemore josemore moved this from Ready For Release to Done in CAOS: Our Daily Bread Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosroman carlosroman carlosroman left review comments

@cristianciutea cristianciutea cristianciutea approved these changes

@noly noly noly left review comments

Assignees

@varas varas

Labels
None yet
Projects
No open projects
CAOS: Our Daily Bread
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@varas @coveralls @carlosroman @noly @cristianciutea @josemore