-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP & TCP integrations API #235
Conversation
ac61e70
to
e95f1da
Compare
Pull Request Test Coverage Report for Build 405526337
💛 - Coveralls |
f257b9d
to
cbb9000
Compare
cbb9000
to
57226c9
Compare
a592a5d
to
1a8c437
Compare
669791c
to
80e1661
Compare
80e1661
to
414a992
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
if err != nil { | ||
s.logger.WithField("port", s.port).WithError(err).Error("trying to listen") | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe worth adding the following?
defer listener.Close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added along with return
Updated HTTP API to support all integration protocols.
Updated HTTP API to support Windows.
Simple TCP socket API. For now limited to:
tcp_server_port
, default8002
You can start playing around by:
nc localhost 8002
(enable withtcp_server_enabled: true
)curl -d "{ "protocol_version": "4", ... }" localhost:8001/v1/data
(enable withhttp_server_enabled: true
)