fix: agent config plugin serialising only public fields #249
Conversation
varas
commented
Nov 24, 2020
•
varas
commented
- agent-config plugin serialising now avoids non public config fields.
- agent-config plugin now submit inventory items in config format, ie. snake-case as YAML (instead of previous camel-case variable name).
varas
force-pushed
the
feat_agt-cfg-serialize-only-publics
branch
2 times, most recently
from
b70d2c8
to
306b88a
Compare
Pull Request Test Coverage Report for Build 487640757
💛 - Coveralls |
pkg/plugins/agent_config.go
Outdated
| continue | ||
| } | ||
| firstLetter := rune(name[0]) | ||
| if unicode.IsLower(firstLetter) { |
There was a problem hiding this comment.
shouldn't we filter them by the "public" annotation?
https://github.com/newrelic/infrastructure-agent/blob/master/pkg/config/config.go#L64
In case that a config option needs to be public in the code but we don't wan't to send the value
There was a problem hiding this comment.
I think that "public" annotation belongs to the past agent closed source history, where we wanted to know whether a config option was meant to be publicly announced.
There was a problem hiding this comment.
BTW do we still use this "public" anno for something?
There was a problem hiding this comment.
Used for discriminating which fields should be logged and now we'll be using it for agent config inventory plugin.
There was a problem hiding this comment.
LGTM, just one small question
https://github.com/newrelic/infrastructure-agent/pull/249/files#r530889786
varas
dismissed stale reviews from cristianciutea and carlosroman
via
83797d1
varas
force-pushed
the
feat_agt-cfg-serialize-only-publics
branch
from
ac3de28
to
83797d1
Compare
varas
changed the title
varas
force-pushed
the
feat_agt-cfg-serialize-only-publics
branch
from
83797d1
to
90f732f
Compare
varas
force-pushed
the
feat_agt-cfg-serialize-only-publics
branch
from
90f732f
to
f90383f
Compare
