Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renames parser to filter in log forwarder #255

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Renames parser to filter in log forwarder #255

merged 1 commit into from
Nov 27, 2020

Conversation

jsubirat
Copy link
Contributor

No description provided.

@jsubirat jsubirat force-pushed the renames_parser_to_filter_in_log_forwarder branch from 70516e4 to d6d6ae6 Compare November 26, 2020 16:43
@coveralls
Copy link

Pull Request Test Coverage Report for Build 385627887

  • 18 of 20 (90.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 58.219%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/integrations/v4/logs/cfg.go 18 20 90.0%
Files with Coverage Reduction New Missed Lines %
pkg/metrics/sampler/sampler_routine.go 2 94.74%
Totals Coverage Status
Change from base Build 385608560: 0.02%
Covered Lines: 11234
Relevant Lines: 19296
💛 - Coveralls

jodstrcil
jodstrcil approved these changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@jodstrcil jodstrcil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varas varas merged commit de13754 into master Nov 27, 2020
@varas varas deleted the renames_parser_to_filter_in_log_forwarder branch November 27, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varas varas varas approved these changes

@jodstrcil jodstrcil jodstrcil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jsubirat @coveralls @varas @jodstrcil