-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event submission on run_integration exit with exit code #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57aee4b
to
5bc79f9
Compare
5bc79f9
to
1359d11
Compare
Pull Request Test Coverage Report for Build 423347383
💛 - Coveralls |
8c0d7c9
to
0efe6e2
Compare
0efe6e2
to
4a74e84
Compare
7536d24
to
f6a89bf
Compare
brushknight
previously approved these changes
Dec 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5e0fc08
to
041a999
Compare
carlosroman
reviewed
Dec 15, 2020
carlosroman
reviewed
Dec 15, 2020
Co-authored-by: Carlos <croman@newrelic.com>
Co-authored-by: Carlos <croman@newrelic.com>
carlosroman
approved these changes
Dec 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrations run by cmd channel submit event when finished containing exit code
Usual instrumentation fields for command channel run/stop integrations are #256 (comment)
This adds a new event when an integration run by command channel stops with the usual fields plus:
summary
value is"integration-exited"
cmd_exit_code
with an integer value being the exit code and negative values on errors:-1
non stopped,-2
non supported (Centos5),-3
for unknown errors on the execution.It also adds a new
cmd_stop_mode
value:"process-not-found"
to the usual list for thestop_integration
event.