Command channel metadata #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 423814981
💛 - Coveralls |
brushknight
reviewed
Dec 14, 2020
pkg/backend/commandapi/client.go
Outdated
| @@ -39,6 +40,12 @@ func (c *Command) Event(integrationName string, integrationArgs []string) protoc | |||
| "cmd_args_name": integrationName, | |||
| "cmd_args_args": fmt.Sprintf("%+v", integrationArgs), | |||
| } | |||
|
|
|||
| for k, v := range metadata { | |||
There was a problem hiding this comment.
do we need to have test for this change?
There was a problem hiding this comment.
good one, we are not testing instrumentation events
There was a problem hiding this comment.
added into latest commit
varas
force-pushed
the
feat_exit-code-event
branch
from
5e0fc08
to
041a999
Compare
carlosroman
reviewed
Dec 15, 2020
josemore
moved this from Ready For Review
to Ready For Release
in CAOS: Our Daily Bread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
metadatafield support for the command channel.metadatais expected to be a key-value pair (dict) which keys are in string format.These
metadatacontents are forwarded to the instrumentation events, by prefixing metadata keys within the event withcmd_metadata..IE:
cmd channel:
becomes event fields: