Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: more verbose connectivity error messages #271

Merged
merged 3 commits into from
Dec 15, 2020
Merged

feat: more verbose connectivity error messages #271

merged 3 commits into from
Dec 15, 2020

Conversation

varas
Copy link
Contributor

@varas varas commented Dec 15, 2020

No description provided.

@varas varas requested a review from a team December 15, 2020 11:14
@coveralls
Copy link

coveralls commented Dec 15, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 423470215

  • 0 of 2 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 58.226%
Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/newrelic-infra/newrelic-infra.go 0 1 0.0%
internal/agent/agent.go 0 1 0.0%
Totals Coverage Status
Change from base Build 415947680: 0.03%
Covered Lines: 11407
Relevant Lines: 19591
💛 - Coveralls

carlosroman
carlosroman previously approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@carlosroman carlosroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varas varas merged commit be333fe into master Dec 15, 2020
@varas varas deleted the feat_verbose-connectivity-error-msgs branch December 15, 2020 15:16
@josemore josemore added this to Ready For Release in CAOS: Our Daily Bread Dec 16, 2020
@varas varas moved this from Ready For Release to Done in CAOS: Our Daily Bread Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosroman carlosroman carlosroman left review comments

Assignees
No one assigned
Labels
None yet
Projects
No open projects
CAOS: Our Daily Bread
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@varas @coveralls @carlosroman