Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop comments from config files #272

Merged
merged 2 commits into from
Dec 16, 2020
Merged

Drop comments from config files #272

merged 2 commits into from
Dec 16, 2020

Conversation

varas
Copy link
Contributor

@varas varas commented Dec 16, 2020 •
edited
Loading

Prior to replace env-vars within config files comments are removed. Therefore env-vars within commented lines are not expanded.

@varas varas requested a review from a team December 16, 2020 11:06
@varas varas changed the title feat: drop commented lines from config files Drop commented lines from config files Dec 16, 2020
@coveralls
Copy link

coveralls commented Dec 16, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 426048676

  • 20 of 24 (83.33%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 58.162%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/config/envvar/envvar.go 20 24 83.33%
Files with Coverage Reduction New Missed Lines %
pkg/integrations/v4/logs/cfg_watcher.go 4 67.5%
Totals Coverage Status
Change from base Build 423826326: 0.04%
Covered Lines: 11433
Relevant Lines: 19657
💛 - Coveralls

brushknight
brushknight approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@brushknight brushknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varas varas changed the title Drop commented lines from config files Drop comments from config files Dec 16, 2020
@varas varas merged commit 7f863c1 into master Dec 16, 2020
@varas varas deleted the feat_drop-commented-lines-from-config branch December 16, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brushknight brushknight brushknight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@varas @coveralls @brushknight