Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SLES-11 service management #275

Merged
merged 2 commits into from
Jan 12, 2021
Merged

fix: SLES-11 service management #275

merged 2 commits into from
Jan 12, 2021

Conversation

varas
Copy link
Contributor

@varas varas commented Dec 16, 2020

No description provided.

@varas varas requested a review from a team December 16, 2020 18:10
@coveralls
Copy link

Pull Request Test Coverage Report for Build 426310431

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 58.142%
Files with Coverage Reduction New Missed Lines %
pkg/integrations/v4/logs/cfg_watcher.go 4 62.5%
Totals Coverage Status
Change from base Build 426275188: -0.02%
Covered Lines: 11429
Relevant Lines: 19657
💛 - Coveralls

@josemore josemore added this to Ready For Review in CAOS: Our Daily Bread Dec 17, 2020
carlosroman
carlosroman approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@carlosroman carlosroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@coveralls
Copy link

coveralls commented Dec 18, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 479992979

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 58.162%
Files with Coverage Reduction New Missed Lines %
pkg/integrations/v4/logs/cfg_watcher.go 4 67.5%
Totals Coverage Status
Change from base Build 426275188: 0.0%
Covered Lines: 11433
Relevant Lines: 19657
💛 - Coveralls

@varas varas merged commit 9f91887 into master Jan 12, 2021
@varas varas deleted the fix_sles11-service-mgmt branch January 12, 2021 11:38
@varas varas moved this from Ready For Review to Ready For Release in CAOS: Our Daily Bread Jan 12, 2021
@varas varas moved this from Ready For Release to Done in CAOS: Our Daily Bread Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosroman carlosroman carlosroman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
CAOS: Our Daily Bread
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@varas @coveralls @carlosroman @noly