Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add fedramp flag & remove gov license prefix #286

Merged
merged 3 commits into from
Jan 20, 2021
Merged

feat: add fedramp flag & remove gov license prefix #286

merged 3 commits into from
Jan 20, 2021

Conversation

varas
Copy link
Contributor

@varas varas commented Jan 18, 2021 •
edited
Loading

  • Adds fedramp: true flag.
  • Removes gov license key prefix handling, as there are no such prefixes.

Details on endpoints: https://docs.newrelic.com/docs/security/security-privacy/compliance/fedramp-compliant-endpoints

Solves #278

@varas varas requested a review from a team January 18, 2021 16:33
@coveralls
Copy link

coveralls commented Jan 18, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 498128478

  • 9 of 10 (90.0%) changed or added relevant lines in 2 files are covered.
  • 18 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.07%) to 58.073%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/config/config.go 6 7 85.71%
Files with Coverage Reduction New Missed Lines %
internal/agent/event_sender_vortex.go 1 73.21%
pkg/metrics/sampler/sampler_routine.go 2 94.74%
pkg/license/license.go 7 26.09%
pkg/integrations/v4/logs/cfg_watcher.go 8 62.5%
Totals Coverage Status
Change from base Build 487663032: -0.07%
Covered Lines: 11416
Relevant Lines: 19658
💛 - Coveralls

noly
noly previously approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@noly noly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, I like when a change is easy to make. ✅

@noly noly dismissed their stale review January 19, 2021 09:02

Does not solve #278, fedramp config miss to setup log url fedramp.

@noly noly linked an issue Jan 19, 2021 that may be closed by this pull request
Add config option to override the endpoint for sending log data #278
Closed
noly
noly reviewed Jan 19, 2021
View reviewed changes
pkg/integrations/v4/logs/cfg.go Outdated
if cfg.IsFedramp {
ret.Endpoint = fedrampEndpoint
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO order of precedence would be: stg, fedramp and last euEndpoint.
So I would move

  if license.IsRegionEU(cfg.License) {
    ret.Endpoint = euEndpoint			
  }

Should be first conditional.
(I don't know how to request a change 😿)

cristianciutea
cristianciutea approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@cristianciutea cristianciutea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varas varas merged commit a17a941 into master Jan 20, 2021
@varas varas deleted the feat_fedramp-flag branch January 20, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noly noly noly left review comments

@cristianciutea cristianciutea cristianciutea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add config option to override the endpoint for sending log data
4 participants
@varas @coveralls @noly @cristianciutea