feat: deployment experience integration allow list for cmd API #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varas
force-pushed
the
feat_dep-exp-allow-list
branch
from
375a267
to
46f4bc3
Compare
Pull Request Test Coverage Report for Build 498124943
💛 - Coveralls |
noly
reviewed
Jan 18, 2021
noly
reviewed
Jan 19, 2021
| {"empty", "", false}, | ||
| {"allowed", "nri-lsi-java", true}, | ||
| {"not allowed", "", false}, | ||
| {"extra suffix", "nri-lsi-java-foo", false}, |
There was a problem hiding this comment.
'empty' and 'not allowed' are the same case. And 'extra suffix' is not allowed as well right?
noly
reviewed
Jan 19, 2021
| @@ -54,6 +56,10 @@ func NewHandler(definitionQ chan<- integration.Definition, il integration.Instan | |||
| return | |||
| } | |||
|
|
|||
| if cmdapi.IsAllowedToRunStopFromCmdAPI(args.IntegrationName) { | |||
| return ErrIntNotAllowed | |||
| } | |||
There was a problem hiding this comment.
Make sense to move it to be the first we validate. Therefore we avoid to 'Unmarshal' if there is no need.
There was a problem hiding this comment.
only previous check is empty case, and I think that's correct, as it should provide its own error, otherwise this IsAllowedToRunStopFromCmdAPI should return a 3rd case (not bool anymore) where it says empty case is not handled
| @@ -26,7 +27,8 @@ const cmdName = "run_integration" | |||
|
|
|||
| // Errors | |||
| var ( | |||
| ErrNoIntName = errors.New("missing required \"integration_name\"") | |||
| ErrNoIntName = errors.New("missing required \"integration_name\"") | |||
| ErrIntNotAllowed = errors.New("integration now allowed to run/stop from command channel") | |||
There was a problem hiding this comment.
small typo here? "now" -> "not"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For security reasons, command channel won't allow arbitrary integration executions. These ones should be listed in the allow-list.