fix: RemoveYAMLComments considering hashtag within strings as comment #302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RemoveYAMLComments considering hashtag within strings as comment.
Golang does not support negative lookaheads golang/go#18868
There's an alternative library https://github.com/dlclark/regexp2 but here we are sticking to stdlib.
For this reason it's required:
We are not trimming whitespaces for simplicity.
This also logs the (previously shadowed) original error on config error.