Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: HTTP APIs enablement flags #597

Merged
merged 1 commit into from
Jun 29, 2021
Merged

fix: HTTP APIs enablement flags #597

merged 1 commit into from
Jun 29, 2021

Conversation

varas
Copy link
Contributor

@varas varas commented Jun 29, 2021 •
edited
Loading

Fixes regression mixing up enablement flags from HTTP APIs: status and data ingest.

Therefore status_server_enabled acted as http_server_enabled and viceversa

@varas varas requested a review from a team June 29, 2021 16:11
brushknight
brushknight approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@brushknight brushknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varas varas merged commit 5b6a40e into master Jun 29, 2021
@varas varas deleted the fix/http-apis-enablement branch June 29, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brushknight brushknight brushknight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@varas @brushknight