-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add memory profiling over time #599
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1fc4c19
to
318752e
Compare
66b7233
to
4d232e8
Compare
varas
reviewed
Jul 1, 2021
varas
reviewed
Jul 1, 2021
varas
reviewed
Jul 1, 2021
varas
reviewed
Jul 1, 2021
varas
reviewed
Jul 1, 2021
varas
reviewed
Jul 1, 2021
varas
reviewed
Jul 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! just some not so relevant comments
But I'm not approving without a user readable usage & behaviour description.
3b6669a
to
13fc0f7
Compare
varas
reviewed
Jul 2, 2021
varas
reviewed
Jul 2, 2021
varas
reviewed
Jul 2, 2021
varas
previously approved these changes
Jul 2, 2021
varas
reviewed
Jul 5, 2021
varas
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Out memory profiler is dumping heap in the beginning of runtime.
Solution
Add interval heap dump over agent runtime
Technical details
MemProfileInterval
yaml:"mem_profile_interval" envconfig:"mem_profile_interval"
that will be set automatically ifMemProfile
present. Default value is 300 seconds (5 minutes) and can be configured by user.MemProfile
variable is set, agent will start creating heap profile eachMemProfileInterval
seconds and save it in the path stored in the variable like PATH_000000300s, PATH_000000600s where 000000300s is agent uptime mark.