Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log truncated or dropped events #634

Merged
merged 1 commit into from Jul 19, 2021
Merged

Log truncated or dropped events #634

merged 1 commit into from Jul 19, 2021

Conversation

varas
Copy link
Contributor

@varas varas commented Jul 9, 2021 •
edited

  • Log truncated or dropped events as warnings
  • Log discarded events by matching rules in debug (will only show up in verbose mode)

@varas varas requested a review from a team July 9, 2021 14:15
@varas varas changed the title feat: log truncated or dropped events Log truncated or dropped events Jul 9, 2021
@varas varas linked an issue Jul 9, 2021 that may be closed by this pull request
Integrations samples on Fargate are not continuously sent #339
Closed
@varas varas force-pushed the log-dropped-truncated-events branch from cd44d7e to 310df95 Compare July 9, 2021 14:21
@varas varas force-pushed the log-dropped-truncated-events branch from 310df95 to cb27aca Compare July 9, 2021 14:21
rubenruizdegauna
rubenruizdegauna reviewed Jul 13, 2021
View reviewed changes
internal/agent/agent.go
if c.cfg.TruncTextValues {
orig := event
event = metric.TruncateLength(event, metric.NRDBLimit)
aclog.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT if we only log it if orig != event ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will remove noice, sounds good

rubenruizdegauna
rubenruizdegauna approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@rubenruizdegauna rubenruizdegauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just small suggestion

brushknight
brushknight approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@brushknight brushknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varas varas merged commit 5b13ad5 into test-integration-protocol-v2 Jul 19, 2021
@varas varas deleted the log-dropped-truncated-events branch July 19, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenruizdegauna rubenruizdegauna rubenruizdegauna approved these changes

@brushknight brushknight brushknight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrations samples on Fargate are not continuously sent
3 participants
@varas @rubenruizdegauna @brushknight