Fix executor.Execute Close and test FD leaks #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varas
force-pushed
the
fix_executor-goroutine-leak
branch
2 times, most recently
from
03ad48e
to
55430c2
Compare
varas
changed the title
varas
force-pushed
the
fix_executor-goroutine-leak
branch
from
55430c2
to
c200243
Compare
rubenruizdegauna
previously approved these changes
Jul 26, 2021
varas
force-pushed
the
fix_executor-goroutine-leak
branch
5 times, most recently
from
82d8c17
to
e6194a1
Compare
varas
force-pushed
the
fix_executor-goroutine-leak
branch
from
e6194a1
to
f8f6a20
Compare
rubenruizdegauna
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After
executor.Execute()callsOutputSend.Close()there are a couple channels that might be handled out of the Execute() context, I noted these down on the test code.It'd be nice to build a larger scope leak test covering those too.