New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update windows go version #745
Conversation
.github/workflows/test.yml
Outdated
@@ -6,6 +6,7 @@ env: | |||
DOCKER_HUB_PASSWORD: ${{ secrets.OHAI_DOCKER_HUB_PASSWORD }} | |||
TAG: "0.0.0" # needed for goreleaser test builds | |||
GO_VERSION: '1.14.4' | |||
WIN_GO_VERSION: '1.16.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we use latest from 1.16? 1.16.8
?
@@ -9,7 +9,7 @@ on: | |||
|
|||
env: | |||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
GO_VERSION: '1.14.4' | |||
GO_VERSION: '1.16.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we use latest from 1.16? 1.16.8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR will increase the version of golang for Windows agent to fix smart HNR issue.