-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: only pass NRIA_PASSTHROUGH_ENVIRONMENT variables to v4 integrations #751
Conversation
64b69a9
to
008c336
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I see |
It is the object populated from config. I'm setting the env vars to be passthrough as if they would be set from config. |
Thanks for clarifying @paologallinaharbur @rubenruizdegauna, it's clear I should not leave review comments before coffee kicks in :P |
8b12fa8
008c336
to
8b12fa8
Compare
Only environment variables that are present in
NRIA_PASSTHROUGH_ENVIRONMENT
should be passed to integration. These should have precedence over the integration ones.