Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only pass NRIA_PASSTHROUGH_ENVIRONMENT variables to v4 integrations #751

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

rubenruizdegauna
Copy link
Contributor

Only environment variables that are present in NRIA_PASSTHROUGH_ENVIRONMENT should be passed to integration. These should have precedence over the integration ones.

cristianciutea
cristianciutea previously approved these changes Sep 27, 2021
Copy link
Contributor

@cristianciutea cristianciutea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@paologallinaharbur paologallinaharbur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roobre
Copy link
Contributor

roobre commented Sep 27, 2021

I see manager_test.go uses a fn called NewManager, which has a new argument. However I'm not seeing that change the in the diff. Am I missing something?

@paologallinaharbur
Copy link
Member

If I understood what you meant, it is not a new parameter, but it is populating a field of the configuration struct:
Screen Shot 2021-09-27 at 10 43 25 AM

@rubenruizdegauna
Copy link
Contributor Author

rubenruizdegauna commented Sep 27, 2021

I see manager_test.go uses a fn called NewManager, which has a new argument. However I'm not seeing that change the in the diff. Am I missing something?

It is the object populated from config. I'm setting the env vars to be passthrough as if they would be set from config.

@roobre
Copy link
Contributor

roobre commented Sep 27, 2021

Thanks for clarifying @paologallinaharbur @rubenruizdegauna, it's clear I should not leave review comments before coffee kicks in :P

@rubenruizdegauna rubenruizdegauna merged commit eadb677 into master Sep 27, 2021
@rubenruizdegauna rubenruizdegauna deleted the fix/nria_passthrough_envi branch September 27, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants