feat: add partition file scanning #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogercoll
requested review from
rubenruizdegauna,
brushknight and
cristianciutea
rogercoll
commented
Dec 20, 2021
| @@ -166,9 +166,6 @@ macos/harvest-tests: deps | |||
| build-harvest-tests: deps | |||
| go test -c ./test/harvest -tags="harvest" -v | |||
|
|
|||
| .PHONY: run-automated-harvest-tests | |||
There was a problem hiding this comment.
Removed as .test/harvest/ansible/automated-test.sh does not exist
rogercoll
force-pushed
the
disk_system_root
branch
from
8c278ad
to
594ad40
Compare
rubenruizdegauna
previously approved these changes
Dec 22, 2021
rogercoll
force-pushed
the
disk_system_root
branch
from
594ad40
to
6ee21cd
Compare
rubenruizdegauna
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partitionsInfo()function could also return a map of partitions being the major and minor numbers the key. To keep aligned with the code like thedeviceMapperInfo()function, a slice is returned. Nonetheless, any feedback is welcomed.