feat(entities): Support custom attributes JSON #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1526 +/- ##
==========================================
+ Coverage 47.40% 47.48% +0.07%
==========================================
Files 125 125
Lines 7716 7742 +26
==========================================
+ Hits 3658 3676 +18
- Misses 3917 3925 +8
Partials 141 141
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
amolero-nr
changed the title
sanderblue
reviewed
Oct 26, 2023
| @@ -127,3 +142,23 @@ func parseCustomAttributes(a *[]string) (*map[string]string, error) { | |||
|
|
|||
| return &customAttributeMap, nil | |||
| } | |||
|
|
|||
| func getCustomAttributes(a []string, b string) (interface{}, error) { | |||
There was a problem hiding this comment.
Can we make this function always return *map[string]interface{} or map[string]interface{} instead of interface{}? Then you won't need to use the switch statement.
There was a problem hiding this comment.
:butting-in-emoji: map[string]interface{}'s zero value is nil since it's a reference type, so no need for*map[string]interface{}
There was a problem hiding this comment.
Thanks, done in ed2172c
sanderblue
approved these changes
Oct 30, 2023
mbazhlekova
added a commit
that referenced
this pull request
Oct 30, 2023
This reverts commit a37c703.
mbazhlekova
added a commit
that referenced
this pull request
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports JSON strings for
--customAttributesfor deployment markers. Ref: NR-165686.