Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboards): remove omitempty on widgets to allow creating pages with no widgets #1033

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

pranav-new-relic
Copy link
Member

@pranav-new-relic pranav-new-relic commented Jun 15, 2023

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023

Codecov Report

Merging #1033 (7afe6a4) into main (4c18484) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1033   +/-   ##
=======================================
  Coverage   41.62%   41.62%           
=======================================
  Files          79       79           
  Lines        4956     4956           
=======================================
  Hits         2063     2063           
  Misses       2745     2745           
  Partials      148      148           
Flag Coverage Δ
unit 41.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@NSSPKrishna
Copy link
Member

@pranav-new-relic, should a comment be added to Tutone file, mentioning the avoidance of generating this specific type?

@pranav-new-relic
Copy link
Member Author

pranav-new-relic commented Jun 19, 2023

@pranav-new-relic, should a comment be added to Tutone file, mentioning the avoidance of generating this specific type?

Thanks for the suggestion; I'll add a comment above these modified datatypes to not be generated/modified via tutone.

@pranav-new-relic pranav-new-relic merged commit 7ba7df9 into main Jun 19, 2023
7 of 9 checks passed
@pranav-new-relic pranav-new-relic deleted the fix/dashboard-widgets-empty branch June 19, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants