Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nrql_alert_conditions): Add data_account_id for NRQL alert condition #1184

Conversation

founddrama
Copy link
Contributor

Adds support for the new data_account_id field for NRQL alert conditions. This field already appears as dataAccountId in the nrql block for NRQL alert conditions in the NerdGraph GraphQL API. This new field is entering a limited preview and is feature flagged such that it has customer visibility for read operations, but creates and updates are guarded with the feature flag in the downstream service.

This field is a prerequisite for support being added in the Terraform provider (pull request pending)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.24%. Comparing base (3ff4ee2) to head (bc91460).
Report is 58 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1184      +/-   ##
==========================================
- Coverage   38.84%   38.24%   -0.60%     
==========================================
  Files          86       95       +9     
  Lines        5612     4787     -825     
==========================================
- Hits         2180     1831     -349     
+ Misses       3266     2781     -485     
- Partials      166      175       +9     
Flag Coverage Δ
unit 38.24% <ø> (-0.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants