chore(tools): move dep tracking for tools to tools package #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jthurman42
added this to Feature Backlog
in NR1 Developer Toolkit Community
via automation
jthurman42
moved this from Feature Backlog
to Ready for review
in NR1 Developer Toolkit Community
jthurman42
commented
Jan 5, 2021
|
|
||
| GOTOOLS ?= $(shell cd $(TOOL_DIR) && go list -f '{{ .Imports }}' -tags tools |tr -d '[]') |
There was a problem hiding this comment.
Neet trick, any imports defined in this package will become tools to install. No more need to += them constantly
NR1 Developer Toolkit Community
automation
moved this from Ready for review
to Review completed
Jan 5, 2021
zlesnr
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving dep tracking for pipeline tooling to
tools/go.modso they aren't hard deps on the main package. I believe this is causing some issues with importers of the client library, specifically terraform-provider-newrelic.