feat(agentapplication): add ability to manage browser applications #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderblue
force-pushed
the
feat/agent-application-configuration
branch
from
0996bd9
to
9282f02
Compare
sanderblue
changed the title
sanderblue
force-pushed
the
feat/agent-application-configuration
branch
from
9282f02
to
6e01271
Compare
sanderblue
force-pushed
the
feat/agent-application-configuration
branch
5 times, most recently
from
c4fe5d2
to
fa019aa
Compare
rthorn-nr
previously approved these changes
Mar 6, 2023
sanderblue
force-pushed
the
feat/agent-application-configuration
branch
from
fa019aa
to
d910868
Compare
sanderblue
force-pushed
the
feat/agent-application-configuration
branch
from
d910868
to
8e4153a
Compare
Codecov Report
@@ Coverage Diff @@
## main #991 +/- ##
==========================================
+ Coverage 40.59% 40.60% +0.01%
==========================================
Files 77 77
Lines 4880 4881 +1
==========================================
+ Hits 1981 1982 +1
Misses 2755 2755
Partials 144 144
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rthorn-nr
approved these changes
Mar 7, 2023
Julien4218
reviewed
Mar 7, 2023
| // letters to the end of the name. | ||
| // | ||
| // Example random name: nr-test-xmnvb | ||
| func GenerateRandomName(randCharCount int) string { |
There was a problem hiding this comment.
@sanderblue this seems to only be used in a single test file, perhaps this should move in that test file?
There was a problem hiding this comment.
I'll be updating other tests to use it shortly 😉
RavitejaSurampudi
pushed a commit
that referenced
this pull request
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: terraform-provider-newrelic
Note: We currently can't return
apmSettings.alias(this was manually removed from the mutation) in theagentApplicationSettingsUpdateresponse due to a known error resolving that field on the API side. We can probably move forward without this for the time being.