Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Task updates #196

Merged
merged 1 commit into from Sep 29, 2023
Merged

feat: Task updates #196

merged 1 commit into from Sep 29, 2023

Conversation

daffinito
Copy link
Contributor

@daffinito daffinito commented Sep 29, 2023 •
edited

Issue

  • Dotnet/Config/Agent success formatting
    • "Summary": "Found1.NET agent config files.",
  • Ruby logging env variables not included in logHelpers

Goals

Implementation Details

  • Updated the formatting to include spaces around the count of config files found
    • "Summary": "Found 1 .NET agent config files.",
  • Added the env variables for ruby logs

How to Test

go test ./...
Smoke test on Windows
Smoke test on host with Ruby app

cade-conklin
cade-conklin approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@cade-conklin cade-conklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@daffinito daffinito merged commit d09f5ba into main Sep 29, 2023
13 checks passed
@daffinito daffinito deleted the daffi/task-fixes branch September 29, 2023 17:39
@daffinito daffinito mentioned this pull request Oct 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cade-conklin cade-conklin cade-conklin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daffinito @cade-conklin