fix: Base/Config/Validate panic #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daffinito
force-pushed
the
daffi/issue-201
branch
from
35a1581
to
a31d39f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#201
Goals
Resolve panic
Implementation Details
I added a function
formatJsthat formats the newrelic.js file into the format expected byparseJsand removes comments. I also removed any comment logic fromparseJssince it'll all be parsed out informatJs.I found that multiline arrays values weren't having the quotes removed like the rest of the values, so I fixed that as well.
How to Test
go test ./...