fix: During browser agent injection, don't set ContentLength if heade…

…rs have already been sent. Resolves #2051 (#2059)
newrelic · Nov 13, 2023 · c191aa6 · c191aa6
1 parent d0b8d26
commit c191aa6
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/...Relic/Agent/Extensions/Providers/Wrapper/AspNetCore6Plus/BrowserInjectingStreamWrapper.cs b/...Relic/Agent/Extensions/Providers/Wrapper/AspNetCore6Plus/BrowserInjectingStreamWrapper.cs
@@ -39,7 +39,8 @@ public override Task FlushAsync(CancellationToken cancellationToken)
         {
             if (!Disabled && !_isContentLengthSet && IsHtmlResponse())
             {
-                _context.Response.ContentLength = null;
+                if (!_context.Response.HasStarted)  // can't set headers if response has already started
+                    _context.Response.ContentLength = null;
                 _isContentLengthSet = true;
             }
 
@@ -154,7 +155,7 @@ private bool IsHtmlResponse(bool forceReCheck = false)
                 // * text/html response
                 // * UTF-8 formatted (either explicitly or no charset defined)
                 _isHtmlResponse =
-                    _context.Response.ContentType != null && 
+                    _context.Response.ContentType != null &&
                     _context.Response.ContentType.Contains("text/html", StringComparison.OrdinalIgnoreCase) &&
                     (_context.Response.ContentType.Contains("utf-8", StringComparison.OrdinalIgnoreCase) ||
                      !_context.Response.ContentType.Contains("charset=", StringComparison.OrdinalIgnoreCase));
@@ -170,7 +171,8 @@ private bool IsHtmlResponse(bool forceReCheck = false)
                 // and fail when it doesn't match if (_isHtmlResponse.Value)
                 if (!_isContentLengthSet && _context.Response.ContentLength != null)
                 {
-                    _context.Response.ContentLength = null;
+                    if (!_context.Response.HasStarted) // can't set headers if response has already started
+                        _context.Response.ContentLength = null;
                     _isContentLengthSet = true;
                 }
             }