fix: Add missing instrumentation to MSI installer #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrcventura
requested review from
a team,
jaffinito,
nr-ahemsath,
chynesNR and
tippmar-nr
|
#1571 should fix the error reported by the failing Check Markdown links job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a pull request. Please review our contributing guidelines and code of conduct.
Description
The MSI installer was not configured to install the CosmosDb instrumentation files. This PR adds the missing files to the MSI installer, and restores the tests that attempt to detect if instrumentation is missing from the MSI installer configuration files.
The ArtifactBuilder was run locally to validate that the configuration tests are working. These tests detected that the MSI installer did not include the CosmosDb instrumentation.
Author Checklist
[ ] Unit tests, Integration tests, and Unbounded tests completed[ ] Performance testing completed with satisfactory results (if required)Reviewer Checklist