Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect transaction name change reported in logs when SetTransactionName is called multiple times #1857

Closed
nrcventura opened this issue Aug 22, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@nrcventura
Copy link
Member

Description

FINEST level logs generated by CandidateTransactionName.TrySet are not accurate if the SetTransactionName API method is called multiple times in a single transaction. Currently the agent logs indicate that the transaction name specified in the second call to the SetTransactionName API is ignored, but the code does not ignore that name and instead keeps it. The log message is incorrect.

Expected Behavior

If the current transaction name, and the new transaction name both have a priority of User, the log message should indicate that the transaction name is changed to the new transaction name. Doing this will make the log message consistent with the actual logic.

Troubleshooting or NR Diag results

Steps to Reproduce

  1. Create a transaction
  2. Call the SetTransactionName API with a value such as NameFromFirstCall
  3. Call the SetTransactionName API with a new value such as NameFromSecondCall
  4. Observe that the logs indicate that the transaction name NameFromSecondCall is ignored, even though the transaction data shows that the transaction name is NameFromSecondCall is used for the transaction event and the scoped metrics.

For Maintainers Only or Hero Triaging this bug
Suggested Priority (P1,P2,P3,P4,P5): P4
Suggested T-Shirt size (S, M, L, XL, Unknown): S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants